[GitHub] [calcite] chucheng92 commented on a diff in pull request #3366: [CALCITE-5909] Failed SqlParserTest#testNoUnintendedNewReservedKeywords and not covered by build pipeline

Tue, 22 Aug 2023 18:15:13 -0700 


chucheng92 commented on code in PR #3366:
URL: https://github.com/apache/calcite/pull/3366#discussion_r1302342558


##########
core/src/main/codegen/templates/Parser.jj:
##########
@@ -7462,6 +7462,8 @@ SqlIdentifier ReservedFunctionName() :
     |   <NTILE>
     |   <NULLIF>
     |   <OCTET_LENGTH>
+    |   <PERCENTILE_CONT>
+    |   <PERCENTILE_DISC>

Review Comment:
   thanks tanner for sharing the background/context. If ReservedFunctionName 
contains this addition, PERCENTILE functions (any form) works well now.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to