olivrlee commented on code in PR #3391: URL: https://github.com/apache/calcite/pull/3391#discussion_r1304822219
########## core/src/main/java/org/apache/calcite/sql/fun/SqlLibraryOperators.java: ########## @@ -1700,6 +1700,15 @@ private static RelDataType deriveTypeMapFromEntries(SqlOperatorBinding opBinding OperandTypes.NUMERIC_NUMERIC, SqlFunctionCategory.NUMERIC); + /** The "SAFE_DIVIDE(numeric1, numeric2)" function; equivalent to the {@code /} operator but + * returns null if an error occurs, such as division by zero. */ Review Comment: nit: add to comment a part about overflow, since other areas seem to mention it too -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@calcite.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org