[GitHub] [calcite] JiajunBernoulli commented on a diff in pull request #3391: [CALCITE-5933] Add SAFE_DIVIDE function (enabled in BigQuery library)

[via GitHub]

JiajunBernoulli commented on code in PR #3391:
URL: https://github.com/apache/calcite/pull/3391#discussion_r1306600387


##########
testkit/src/main/java/org/apache/calcite/test/SqlOperatorTest.java:
##########
@@ -7332,81 +7332,153 @@ private static void checkIf(SqlOperatorFixture f) {
   @Test void testSafeAddFunc() {
     final SqlOperatorFixture f0 = 
fixture().setFor(SqlLibraryOperators.SAFE_ADD);
     f0.checkFails("^safe_add(2, 3)^",
-        "No match found for function signature "

Review Comment:
   Sometimes, I encounter the same situation  if I commit by IntelliJ IDEA.
   
   I will manually restore them to avoid damaging the git history.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@calcite.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org