jiefei30 commented on PR #3399: URL: https://github.com/apache/calcite/pull/3399#issuecomment-1695862541
> @jiefei30 Happy you're working on this, as I was looking for that feature myself. > > Just a question, doesn't `RelToSqlConverter` also warrants an update on `visitAntiOrSemiJoin`? It looks like it's currently parsing `ANTI` joins as `NOT EXISTS`, but with your addition it could become a `LEFT_ANTI_JOIN` instead? @linorosa Yeah, but I think the `LEFT ANTI JOIN` needs to be identified during the SQL parsing, it's a real syntax of Spark, otherwise it cannot be converted to RelNode, this is a bad case. And parsing `ANTI` joins as `NOT EXISTS` should be a matter of the semantic analysis stage, such as during a validation -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
