jiefei30 commented on code in PR #3399:
URL: https://github.com/apache/calcite/pull/3399#discussion_r1328200661
##########
core/src/main/codegen/templates/Parser.jj:
##########
@@ -1988,8 +1988,8 @@ SqlLiteral JoinType() :
}
{
(
- LOOKAHEAD(3) // required for "LEFT SEMI JOIN" in Babel
Review Comment:
In fact, I also have doubts about this `LOOKAHEAD(3)`, because `LEFT ANTI
JOIN` also requires it, otherwise it will recognize errors, but `LOOKAHEAD(3)`
is outside `<#list>`, so `joinType = ${method} ()` will generate
`LOOKAHEAD(2)` except for the first one `LEFT SEMI JOIN`. Give me some time to
think about it and reply to you as soon as possible
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
