tanclary commented on code in PR #3423:
URL: https://github.com/apache/calcite/pull/3423#discussion_r1326526967
##########
core/src/main/java/org/apache/calcite/sql/fun/SqlItemOperator.java:
##########
@@ -78,7 +78,13 @@ public SqlItemOperator(String name,
SqlWriter writer, SqlCall call, int leftPrec, int rightPrec) {
call.operand(0).unparse(writer, leftPrec, 0);
final SqlWriter.Frame frame = writer.startList("[", "]");
- call.operand(1).unparse(writer, 0, 0);
+ if (offset == 0) {
Review Comment:
Ah I see what you're saying. Yeah I believe when I originally added this
cluster of functions that I essentially pair the OFFSET operator with ITEM
because at the time they seemed identical. Admittedly I did not give enough
thought to the unparsing so maybe treating them more independently would help
also, given that that approach seems to work for most other BQ-specific
operators.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
