JiajunBernoulli commented on code in PR #3423:
URL: https://github.com/apache/calcite/pull/3423#discussion_r1327918095
##########
core/src/main/java/org/apache/calcite/sql/fun/SqlItemOperator.java:
##########
@@ -50,13 +50,19 @@
public class SqlItemOperator extends SqlSpecialOperator {
public final int offset;
public final boolean safe;
+ /** Set to true if this is a simple index.
+ * The semantics of the array index and SAFE_ORDINAL is identical;
+ * this field tells them apart. It is set to 'false' for SAFE_ORDINAL.
+ */
+ public final boolean simple;
public SqlItemOperator(String name,
SqlSingleOperandTypeChecker operandTypeChecker,
- int offset, boolean safe) {
+ int offset, boolean safe, boolean simple) {
Review Comment:
I think `String funcId` is more valuable than `boolean simple`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
