olivrlee commented on code in PR #227:
URL: https://github.com/apache/calcite-avatica/pull/227#discussion_r1326549967
##########
core/src/main/java/org/apache/calcite/avatica/MetaImpl.java:
##########
@@ -388,6 +388,32 @@ public MetaColumn(
public String getName() {
return columnName;
}
+ public static String[] getColumnNames() {
Review Comment:
The reason why I kept that was because of how `createResultSet` is set up to
take in the varags.
I could restructure `createResultSet` to work with `List<String>`
What would be the best way to instantiate this when considering the number
of copies?
How is:
```
public static final List<String> COLUMN_NAMES = Collections.unmodifiableList(
Arrays.asList("TABLE_CAT",
"TABLE_SCHEM",
"TABLE_NAME",
"TABLE_TYPE",
"REMARKS",
"TYPE_CAT",
"TYPE_SCHEM",
"TYPE_NAME",
"SELF_REFERENCING_COL_NAME",
"REF_GENERATION"));
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
