barrkel commented on code in PR #227:
URL: https://github.com/apache/calcite-avatica/pull/227#discussion_r1326567697


##########
core/src/main/java/org/apache/calcite/avatica/MetaImpl.java:
##########
@@ -388,6 +388,32 @@ public MetaColumn(
     public String getName() {
       return columnName;
     }
+    public static String[] getColumnNames() {

Review Comment:
   So if it's most ergonomic as a string array, then just new up a string array 
directly rather than going through asList -> toArray. As in `return new 
String[] { "TABLE_CAT", "TABLE_SCHEM", ... };`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to