tanclary commented on code in PR #3430:
URL: https://github.com/apache/calcite/pull/3430#discussion_r1333231129
##########
core/src/main/java/org/apache/calcite/sql/type/ReturnTypes.java:
##########
@@ -645,6 +645,13 @@ public static SqlCall stripSeparator(SqlCall call) {
public static final SqlReturnTypeInference TO_ARRAY =
ARG0.andThen(SqlTypeTransforms.TO_ARRAY);
+ /**
+ * Same as {@link #TO_ARRAY} but returns with nullability if any of the
Review Comment:
Would you mind updating this javadoc to match the format of other
`*_NULLABLE` return types? Here is `DATE` and `DATE_NULLABLE` as an example:
```
/**
* Type-inference strategy whereby the result type of a call is DATE.
*/
public static final SqlReturnTypeInference DATE =
explicit(SqlTypeName.DATE);
/**
* Type-inference strategy whereby the result type of a call is nullable
* DATE.
*/
public static final SqlReturnTypeInference DATE_NULLABLE =
DATE.andThen(SqlTypeTransforms.TO_NULLABLE);
```
##########
core/src/main/java/org/apache/calcite/sql/type/ReturnTypes.java:
##########
@@ -645,6 +645,13 @@ public static SqlCall stripSeparator(SqlCall call) {
public static final SqlReturnTypeInference TO_ARRAY =
ARG0.andThen(SqlTypeTransforms.TO_ARRAY);
+ /**
+ * Same as {@link #TO_ARRAY} but returns with nullability if any of the
+ * operands is nullable.
+ */
+ public static final SqlReturnTypeInference ARRAY_NULLABLE =
Review Comment:
Should we name it `TO_ARRAY_NULLABLE` to be consistent with other types?
(for instance, there is `ARG0` and `ARG0_NULLABLE`)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
