mihaibudiu commented on code in PR #3430:
URL: https://github.com/apache/calcite/pull/3430#discussion_r1333381033
##########
testkit/src/main/java/org/apache/calcite/test/SqlOperatorTest.java:
##########
@@ -9314,11 +9314,12 @@ private static void
checkGroupConcatFuncFails(SqlOperatorFixture t) {
}
private static void checkArrayAggFunc(SqlOperatorFixture f) {
- f.setFor(SqlLibraryOperators.ARRAY_CONCAT_AGG, VM_FENNEL, VM_JAVA);
+ f.setFor(SqlLibraryOperators.ARRAY_AGG, VM_FENNEL, VM_JAVA);
Review Comment:
I have found that sometimes optimization rules produce results that differ
from the runtime results for the same expression. In particular
`CoreRules.PROJECT_REDUCE_EXPRESSIONS` will optimize constant expressions.
Currently there is no easy way to check that the optimization produces the
expected result. Does the SqlToRelConverterTest allow you to specify
optimizations?
I am working towards https://issues.apache.org/jira/browse/CALCITE-5891,
once that exists all the existing SqlOperatorTests will be automatically run in
both ways. (But it may take awhile, it has uncovered at least 50 bugs in
RelToSql and the optimizer.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
