herunkang2018 commented on code in PR #3317:
URL: https://github.com/apache/calcite/pull/3317#discussion_r1342140349
##########
core/src/main/java/org/apache/calcite/runtime/SqlFunctions.java:
##########
@@ -1076,6 +1076,32 @@ public static int levenshtein(String string1, String
string2) {
return LEVENSHTEIN_DISTANCE.apply(string1, string2);
}
+ /** SQL FIND_IN_SET(string, stringArray) function. */
+ public static int findInSet(String matchStr, String textStr) {
Review Comment:
For null check issue, we can define the null policy of the function, and
null policy will handle null properly in code generation phase, so I think
there is no need to implement null check in each function implementation
additionally.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
