Anthrino commented on code in PR #3460:
URL: https://github.com/apache/calcite/pull/3460#discussion_r1355420195
##########
core/src/main/java/org/apache/calcite/sql/validate/SqlConformanceEnum.java:
##########
@@ -240,6 +240,15 @@ public enum SqlConformanceEnum implements SqlConformance {
}
}
+ @Override public boolean isRegexReplaceCaptureGroupDollarIndexed() {
Review Comment:
Hi @julianhyde, we came up with this approach to identify calls from Big
Query by adding an `isRegexReplaceCaptureGroupDollarIndexed()` method in
`SqlConformanceEnum`.
Like Tanner mentioned, it is a function specific use case so would it be
better instead to create a new BQ specific operator
(`REGEXP_REPLACE_BIG_QUERY`) in `StandardConvertletTable` and point that to the
added custom preprocessing method in `SqlFunctions`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
