Anthrino commented on code in PR #3460:
URL: https://github.com/apache/calcite/pull/3460#discussion_r1369267807
##########
core/src/main/java/org/apache/calcite/sql/validate/SqlConformanceEnum.java:
##########
@@ -240,6 +240,15 @@ public enum SqlConformanceEnum implements SqlConformance {
}
}
+ @Override public boolean isRegexReplaceCaptureGroupDollarIndexed() {
Review Comment:
Thanks for the review @julianhyde, could you please elaborate a bit on which
caching issues you're indicating here. If you meant the caching mechanism you
added to the `RegexFunction` class to reuse previously built `Regex Patterns`,
it's being used by the new function as well through the existing
`regexpReplace` implementation.
Apologies missed your comment above, will look into that!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
