julianhyde commented on code in PR #3346:
URL: https://github.com/apache/calcite/pull/3346#discussion_r1365854521
##########
core/src/main/java/org/apache/calcite/sql/SqlNumericLiteral.java:
##########
@@ -117,7 +117,7 @@ public boolean isExact() {
scaleValue);
}
- // else we have a a float, real or double. make them all double for
+ // else we have a float, real or double. make them all double for
Review Comment:
From context, this appears to be talking about SQL types. SQL types must be
upper-case. SQL's `FLOAT` type is very different to Java's `float` type so it
is very important to be precise.
Fix existing documentation if necessary.
##########
core/src/test/java/org/apache/calcite/test/RelOptRulesTest.java:
##########
@@ -1925,6 +1925,18 @@ private void
checkSemiOrAntiJoinProjectTranspose(JoinRelType type) {
.check();
}
+ /** Test case for <a
href="https://issues.apache.org/jira/browse/CALCITE-5884";>[CALCITE-5884]
+ * Description of ARRAY_TO_STRING function is incomplete</a>. */
Review Comment:
can you follow the existing formatting, of a line break after 'test case
for'.
##########
core/src/test/java/org/apache/calcite/test/RelOptRulesTest.java:
##########
@@ -1925,6 +1925,18 @@ private void
checkSemiOrAntiJoinProjectTranspose(JoinRelType type) {
.check();
}
+ /** Test case for <a
href="https://issues.apache.org/jira/browse/CALCITE-5884";>[CALCITE-5884]
+ * Description of ARRAY_TO_STRING function is incomplete</a>. */
+ @Test void testArrayToString() {
+ final String sql = "select
array_to_string(array['1','2','3','4',NULL,'6'], ',', NULL)";
+ sql(sql).withFactory(
+ t -> t.withOperatorTable(
Review Comment:
add a comment for what the desried outcome is. I guess we don't want to see
the expression constant-reduced to NULL?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
