libenchao commented on code in PR #3346:
URL: https://github.com/apache/calcite/pull/3346#discussion_r1378324599
##########
core/src/main/java/org/apache/calcite/runtime/SqlFunctions.java:
##########
@@ -5471,6 +5471,10 @@ public static String arrayToString(List list, String
delimiter) {
/** SQL {@code ARRAY_TO_STRING(array, delimiter, nullText)} function. */
public static String arrayToString(List list, String delimiter, @Nullable
String nullText) {
+ // Note that the SQL function ARRAY_TO_STRING that we implement will return
+ // 'NULL' when the nullText argument is NULL. However, that is handled by
+ // the nullPolicy of the RexToLixTranslator. So here a NULL value
Review Comment:
NIT: redundant spaces (and in above line too)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
