mihaibudiu commented on code in PR #3325:
URL: https://github.com/apache/calcite/pull/3325#discussion_r1376555417
##########
core/src/main/java/org/apache/calcite/sql/SqlWindow.java:
##########
@@ -660,6 +664,12 @@ public boolean isAllowPartial() {
}
}
+ private boolean onlyLiteralBounds(@Nullable SqlNode lowerBound, @Nullable
SqlNode upperBound) {
Review Comment:
This does not seem to check for what the compiler calls "literal", which is
essentially a constant value.
You are checking for specific kinds of bounds. So perhaps this function is
not named properly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
