itiels commented on code in PR #3325:
URL: https://github.com/apache/calcite/pull/3325#discussion_r1376722139
##########
core/src/main/java/org/apache/calcite/sql/SqlWindow.java:
##########
@@ -660,6 +664,12 @@ public boolean isAllowPartial() {
}
}
+ private boolean onlyLiteralBounds(@Nullable SqlNode lowerBound, @Nullable
SqlNode upperBound) {
Review Comment:
Naming is hard.. My thought was literal in the sense of `SqlLiteral`, but I
can see why it's confusing.
Changed it to `onlySymbolBounds`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
