mihaibudiu commented on code in PR #3558:
URL: https://github.com/apache/calcite/pull/3558#discussion_r1412853458
##########
core/src/main/java/org/apache/calcite/sql/SqlBinaryOperator.java:
##########
@@ -171,6 +177,22 @@ private RelDataType convertType(SqlValidator validator,
SqlCall call, RelDataTyp
return type;
}
+ @Nullable Charset getCharsetAfterConvert(SqlBasicCall call, @Nullable
Charset typeCharset) {
Review Comment:
Are there other functions which should preserve charsets?
For example, if you do string concatenation, or cast from CHAR to VARCHAR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
