ILuffZhe commented on code in PR #3558:
URL: https://github.com/apache/calcite/pull/3558#discussion_r1412902703
##########
core/src/main/java/org/apache/calcite/sql/SqlBinaryOperator.java:
##########
@@ -171,6 +177,22 @@ private RelDataType convertType(SqlValidator validator,
SqlCall call, RelDataTyp
return type;
}
+ @Nullable Charset getCharsetAfterConvert(SqlBasicCall call, @Nullable
Charset typeCharset) {
Review Comment:
The `char(5)` has the charset ISO-8859-1 preserved in SqlCollation, so the
charset of `CAST(TRANSLATE("name" using BIG5) AS CHAR(5))` should also be
ISO-8859-1.
I add a test for this, please take a look.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
