Chen768959 commented on code in PR #3557:
URL: https://github.com/apache/calcite/pull/3557#discussion_r1414814579
##########
core/src/test/java/org/apache/calcite/rel/rel2sql/RelToSqlConverterTest.java:
##########
@@ -7453,6 +7453,23 @@ private void checkLiteral2(String expression, String
expected) {
sql(query).withSpark().withLibrary(SqlLibrary.SPARK).ok(expectedSql);
}
+ /** Test case for
+ * <a
href="https://issues.apache.org/jira/browse/CALCITE-6150";>[CALCITE-6150]
Review Comment:
> This is good. Can you break up the strings to make the lines shorter (just
one call per line). Put `+` at the start of the line (per our style checker).
>
> Move the method after `testBigQueryDatetimeFormatFunctions`, which is
similar. (Anywhere but the end of the file.)
I have fixed the code style and moved `testExtract` after `testBigQuery`. I
look forward to your further review. Thank you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
