mihaibudiu commented on code in PR #3574:
URL: https://github.com/apache/calcite/pull/3574#discussion_r1420803714
##########
core/src/main/java/org/apache/calcite/sql/SqlCall.java:
##########
@@ -181,6 +181,10 @@ public int operandCount() {
if
(!this.getOperator().getName().equalsIgnoreCase(that.getOperator().getName())) {
return litmus.fail("{} != {}", this, node);
}
+ // For same name but different kind
+ if (this.getOperator().getKind() != that.getOperator().getKind()) {
Review Comment:
This looks wrong to me, shouldn't this be `return false`?
Doesn't this throw?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
