jiefei30 commented on code in PR #3574:
URL: https://github.com/apache/calcite/pull/3574#discussion_r1421205625
##########
core/src/main/java/org/apache/calcite/sql/SqlCall.java:
##########
@@ -181,6 +181,10 @@ public int operandCount() {
if
(!this.getOperator().getName().equalsIgnoreCase(that.getOperator().getName())) {
return litmus.fail("{} != {}", this, node);
}
+ // For same name but different kind
+ if (this.getOperator().getKind() != that.getOperator().getKind()) {
Review Comment:
@mihaibudiu You mean the test case i write should `return false`? It will
`return true` for now. cause `UNARY_MINUS` and `MINUS` , their names are same,
`-`. But It should probably check the operator. I'll think about this change
again
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
