mihaibudiu commented on code in PR #3579: URL: https://github.com/apache/calcite/pull/3579#discussion_r1425664735
########## testkit/src/main/java/org/apache/calcite/test/SqlOperatorTest.java: ########## @@ -10537,6 +10537,29 @@ private static void checkArrayConcatAggFuncFails(SqlOperatorFixture t) { "[null, foo]", "CHAR(3) ARRAY NOT NULL"); f2.checkScalar("array(null)", "[null]", "NULL ARRAY NOT NULL"); + // check complex type + f2.checkScalar("array(row(1))", "[{1}]", + "RecordType(INTEGER NOT NULL EXPR$0) NOT NULL ARRAY NOT NULL"); + f2.checkScalar("array(row(1, null))", "[{1, null}]", + "RecordType(INTEGER NOT NULL EXPR$0, NULL EXPR$1) NOT NULL ARRAY NOT NULL"); + f2.checkScalar("array(row(null, 1))", "[{null, 1}]", + "RecordType(NULL EXPR$0, INTEGER NOT NULL EXPR$1) NOT NULL ARRAY NOT NULL"); + f2.checkScalar("array(row(1, 2))", "[{1, 2}]", + "RecordType(INTEGER NOT NULL EXPR$0, INTEGER NOT NULL EXPR$1) NOT NULL ARRAY NOT NULL"); + f2.checkFails("^array(row(1, 2), null)^", + "Parameters must be of the same type", false); + f2.checkFails("^array(null, row(1, 2))^", Review Comment: If the fix is not too complicated it should probably be part of this PR. Otherwise you have to check-in these tests which give the wrong result, and then modify them again. But perhaps it's reasonable to make a separate PR if it entails a lot of work. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@calcite.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org