mihaibudiu commented on code in PR #3579:
URL: https://github.com/apache/calcite/pull/3579#discussion_r1424778822
##########
testkit/src/main/java/org/apache/calcite/test/SqlOperatorTest.java:
##########
@@ -10537,6 +10537,29 @@ private static void
checkArrayConcatAggFuncFails(SqlOperatorFixture t) {
"[null, foo]", "CHAR(3) ARRAY NOT NULL");
f2.checkScalar("array(null)",
"[null]", "NULL ARRAY NOT NULL");
+ // check complex type
+ f2.checkScalar("array(row(1))", "[{1}]",
+ "RecordType(INTEGER NOT NULL EXPR$0) NOT NULL ARRAY NOT NULL");
+ f2.checkScalar("array(row(1, null))", "[{1, null}]",
+ "RecordType(INTEGER NOT NULL EXPR$0, NULL EXPR$1) NOT NULL ARRAY NOT
NULL");
+ f2.checkScalar("array(row(null, 1))", "[{null, 1}]",
+ "RecordType(NULL EXPR$0, INTEGER NOT NULL EXPR$1) NOT NULL ARRAY NOT
NULL");
+ f2.checkScalar("array(row(1, 2))", "[{1, 2}]",
+ "RecordType(INTEGER NOT NULL EXPR$0, INTEGER NOT NULL EXPR$1) NOT NULL
ARRAY NOT NULL");
+ f2.checkFails("^array(row(1, 2), null)^",
+ "Parameters must be of the same type", false);
+ f2.checkFails("^array(null, row(1, 2))^",
Review Comment:
With the rule you give it is impossible to create a constant array with type
`RecordType(...) ARRAY` which contains a `NULL` value. In other words, I think
that the example that fails should actually be legal code. Clearly the NULL
type is not isStruct(), but they can be both unified by a type which is a
nullable struct.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
