asolimando commented on PR #3563:
URL: https://github.com/apache/calcite/pull/3563#issuecomment-1855629734
> @libenchao Thanks. Do I understand correctly that this test run is not
required (in general) to merge a PR?
They are not, but they will be run when the PR is merged, for changes to
core functions that can have a broad impact I'd say it's recommended, in order
to catch issues early on without waiting for the `main` branch to break.
What is a "core function" is a fuzzy definition though, you can look for the
`@Tag("slow")` tag to get a sense of that is covered by slow tests (even
though, the scope is pretty broad).
If anyone has some more precise recommendations on this topic, I guess it
would be a great addition to the developer's guide on the website.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
