mihaibudiu commented on code in PR #3587:
URL: https://github.com/apache/calcite/pull/3587#discussion_r1431718473
##########
core/src/test/java/org/apache/calcite/rel/rel2sql/RelToSqlConverterTest.java:
##########
@@ -7382,6 +7382,25 @@ private void checkLiteral2(String expression, String
expected) {
sql(sql6).ok(expected6);
}
+ /** Test case for
+ * <a
href="https://issues.apache.org/jira/browse/CALCITE-6116";>[CALCITE-6116]
+ * Add EXISTS function (enabled in Spark library)</a>. */
+ @Test void testExistsFunctionInSpark() {
Review Comment:
how about more negative tests?
the type checker suggests that the function could take any arguments, so how
about some tests where the function signature does not match the array element?
For example functions that take strings, doubles, dates, etc.
##########
core/src/test/java/org/apache/calcite/rel/rel2sql/RelToSqlConverterTest.java:
##########
@@ -7382,6 +7382,25 @@ private void checkLiteral2(String expression, String
expected) {
sql(sql6).ok(expected6);
}
+ /** Test case for
+ * <a
href="https://issues.apache.org/jira/browse/CALCITE-6116";>[CALCITE-6116]
+ * Add EXISTS function (enabled in Spark library)</a>. */
+ @Test void testExistsFunctionInSpark() {
Review Comment:
Also, a test where the function does not return bool.
##########
core/src/test/java/org/apache/calcite/rel/rel2sql/RelToSqlConverterTest.java:
##########
@@ -7382,6 +7382,25 @@ private void checkLiteral2(String expression, String
expected) {
sql(sql6).ok(expected6);
}
+ /** Test case for
+ * <a
href="https://issues.apache.org/jira/browse/CALCITE-6116";>[CALCITE-6116]
+ * Add EXISTS function (enabled in Spark library)</a>. */
+ @Test void testExistsFunctionInSpark() {
Review Comment:
also, a test with an empty array
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
