julianhyde commented on code in PR #3587:
URL: https://github.com/apache/calcite/pull/3587#discussion_r1432068790
##########
site/_docs/reference.md:
##########
@@ -3132,6 +3133,10 @@ parameters:
| identifier
{% endhighlight %}
+| C | Operator syntax | Description
+|:- |:-----------------------------------------------|:-----------
+| s | EXISTS(array, predicate) | Returns whether a
*predicate* holds for one or more elements in the *array*
+
Review Comment:
I don't think you need this table twice in the same file. I think you should
replace this table with a paragraph 'Examples of functions with a lambda
argument are EXISTS, ...'.
##########
core/src/test/resources/sql/higher-order-functions.iq:
##########
@@ -0,0 +1,90 @@
+# higher-order-functions.iq - Queries involving higher-order functions
Review Comment:
Can you rename this file to `lambda.iq`?
It's debatable whether SQL lambdas are true higher-order functions.
##########
site/_docs/reference.md:
##########
@@ -2730,6 +2730,7 @@ BigQuery's type system uses confusingly different names
for types and functions:
| p | DIFFERENCE(string, string) | Returns a measure of
the similarity of two strings, namely the number of character positions that
their `SOUNDEX` values have in common: 4 if the `SOUNDEX` values are same and 0
if the `SOUNDEX` values are totally different
| b | ENDS_WITH(string1, string2) | Returns whether
*string2* is a suffix of *string1*
| o | EXTRACT(xml, xpath, [, namespaces ]) | Returns the XML
fragment of the element or elements matched by the XPath expression. The
optional namespace value that specifies a default mapping or namespace mapping
for prefixes, which is used when evaluating the XPath expression
+| s | EXISTS(array, predicate) | Returns whether a
*predicate* holds for one or more elements in the *array*
Review Comment:
you should describe what the `predicate` argument means. Not in this row,
but before the table, where other arguments are described.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
