kramerul commented on code in PR #3562:
URL: https://github.com/apache/calcite/pull/3562#discussion_r1439414043
##########
core/src/test/java/org/apache/calcite/test/JdbcAdapterTest.java:
##########
@@ -1147,6 +1153,52 @@ private LockWrapper exclusiveCleanDb(Connection c)
throws SQLException {
});
}
+ @Test void testBatchNestedLoopJoinPlan() {
+ final String sql = "SELECT *\n"
+ + "FROM \"s\".\"emps\" A\n"
+ + "LEFT OUTER JOIN \"foodmart\".\"store\" B ON A.\"empid\" =
B.\"store_id\"";
+ final String explain = "JdbcFilter(condition=[OR(=($cor0.empid0, $0),
=($cor1.empid0, $0)";
+ final String jdbcSql = "SELECT *\n"
+ + "FROM \"foodmart\".\"store\"\n"
Review Comment:
I think one test should be enough, as only one additional execution path is
added to the code.
```java
Context context = correlTableMap.get(variable.id);
if (context != null) {
return context;
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
