HanumathRao commented on code in PR #3640:
URL: https://github.com/apache/calcite/pull/3640#discussion_r1459921376
##########
core/src/main/java/org/apache/calcite/prepare/Prepare.java:
##########
@@ -293,13 +293,6 @@ public PreparedResult prepareSql(
root = root.withRel(decorrelate(sqlToRelConverter, sqlQuery, root.rel));
}
- if (configHolder.get().isTrimUnusedFields()) {
Review Comment:
As explained it in the PR description, calling trimUnusedFields is different
in different paths (In the Prepare path we call the trimUnusedFields first
before optimization but seems like the preferred way as implemented in
PlannerImpl is to skip the trimUnusedFields first and call later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
