chucheng92 commented on code in PR #3643:
URL: https://github.com/apache/calcite/pull/3643#discussion_r1462649966
##########
core/src/main/java/org/apache/calcite/runtime/SqlFunctions.java:
##########
@@ -5204,7 +5204,11 @@ public static List compact(List list) {
public static List arrayAppend(List list, Object element) {
final List result = new ArrayList(list.size() + 1);
result.addAll(list);
- result.add(element);
+ if (element instanceof Byte) {
+ result.add(((Byte) element).intValue());
Review Comment:
+1 can't do this. we must make sure when you call `arrayAppend` the input
`List` already is a isomorphic result list (a result list has same operand's
type). so it means we need an explicit casting before you call SqlFunctions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
