JiajunBernoulli commented on code in PR #3653:
URL: https://github.com/apache/calcite/pull/3653#discussion_r1467612425


##########
core/src/main/java/org/apache/calcite/util/format/FormatElementEnum.java:
##########
@@ -48,7 +48,8 @@ public enum FormatElementEnum implements FormatElement {
       sb.append(String.format(Locale.ROOT, "%2d", calendar.get(Calendar.YEAR) 
/ 100 + 1));
     }
   },
-  D("F", "The weekday (Monday as the first day of the week) as a decimal 
number (1-7)") {
+  // TODO: Parsing of weekdays with sunday as first day of the week

Review Comment:
   Why use Todo?
   Can we finish it in the ticket?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to