julianhyde commented on code in PR #3653:
URL: https://github.com/apache/calcite/pull/3653#discussion_r1470137795
##########
core/src/main/java/org/apache/calcite/util/format/FormatElementEnum.java:
##########
@@ -48,7 +48,8 @@ public enum FormatElementEnum implements FormatElement {
sb.append(String.format(Locale.ROOT, "%2d", calendar.get(Calendar.YEAR)
/ 100 + 1));
}
},
- D("F", "The weekday (Monday as the first day of the week) as a decimal
number (1-7)") {
+ // TODO: Parsing of weekdays with sunday as first day of the week
Review Comment:
Please remove the TODO, log a jira case.
##########
core/src/test/java/org/apache/calcite/util/format/FormatElementEnumTest.java:
##########
@@ -77,8 +80,26 @@ class FormatElementEnumTest {
assertFormatElement(FormatElementEnum.FF6, "2014-09-30T10:00:00.123456Z",
"000123");
}
- @Test void testIW() {
- assertFormatElement(FormatElementEnum.IW, "2014-09-30T10:00:00Z", "40");
+ @Test void testID() {
+ assertFormatElement(FormatElementEnum.ID, "2014-09-30T10:00:00Z", "2");
+ }
Review Comment:
I don't understand why some of the tests in this class are parameterized and
others are not.
Frankly I don't think the framework is helping make the tests more
understandable. I would move to code, and add comments if a test is testing
something subtle.
It seems to me that this test class should be very simple.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
