mihaibudiu commented on PR #3669:
URL: https://github.com/apache/calcite/pull/3669#issuecomment-1925877552

   > > Just a question, how to ensure that the semantics of these functions are 
consistent with those in SPARK?
   > 
   > @macroguo-ghy I executed the Function Sqls in the spark engine. And 
checked the function Definition/OperandType/ReturnType is consistent with the 
Spark definition.
   
   Some functions have subtle differences for corner cases of the arguments. 
And Calcite tests often do *not* test the corner cases. I haven't checked Spark 
in particular, but we are writing a lot of tests for existing functions and we 
find lots of such cases. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to