YiwenWu commented on PR #3669: URL: https://github.com/apache/calcite/pull/3669#issuecomment-1926099902
> > > > Just a question, how to ensure that the semantics of these functions are consistent with those in SPARK? > > > > > > > > > @macroguo-ghy I executed the Function Sqls in the spark engine. And checked the function Definition/OperandType/ReturnType is consistent with the Spark definition. > > > > > > Some functions have subtle differences for corner cases of the arguments. And Calcite tests often do _not_ test the corner cases. I haven't checked Spark in particular, but we are writing a lot of tests for existing functions and we find lots of such cases. > > In fact, it's difficult for us to handle all situations. There are also slight differences in functions between different Spark versions. Many behaviors should be left to users to decide based on their Spark version. yes，Engine version is another question that also confuses us -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
