bchapuis commented on code in PR #3668:
URL: https://github.com/apache/calcite/pull/3668#discussion_r1487541098


##########
core/src/main/java/org/apache/calcite/adapter/jdbc/JdbcSchema.java:
##########
@@ -433,6 +433,12 @@ private static RelDataType sqlType(RelDataTypeFactory 
typeFactory, int dataType,
                 typeFactory.createSqlType(SqlTypeName.ANY), true);
       }
       return typeFactory.createArrayType(component, -1);
+    case OTHER:

Review Comment:
   Yes, the use of OTHER with a "geometry" type name seems specific to the 
postgresql jdbc driver and postgis. I guess they did this to distinguish 
postgis geometry types from the regular geometry types implemented in 
postgresql. https://www.postgresql.org/docs/current/datatype-geometric.html
   
   I will clarify this with a comment and try to investigate regular geometry 
data types a bit more.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@calcite.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to