bchapuis commented on code in PR #3668:
URL: https://github.com/apache/calcite/pull/3668#discussion_r1488560237
##########
core/src/test/java/org/apache/calcite/sql/test/SqlTypeNameTest.java:
##########
@@ -172,7 +173,7 @@ class SqlTypeNameTest {
@Test void testOther() {
SqlTypeName tn =
SqlTypeName.getNameForJdbcType(Types.OTHER);
- assertEquals(null, tn, "OTHER did not map to null");
+ assertEquals(OTHER, tn, "OTHER did not map to null");
Review Comment:
I remember modifying this line and found the test cases unclear (and I
forgot to adapt the error message). The javadoc of getNameForJdbcType states:
"corresponding SqlTypeName, or null if the type is not known". As other is kind
of a known type, does it makes sense to adapt the test accordingly? I will
commit this fix for now.
```java
@Test void testOther() {
SqlTypeName tn =
SqlTypeName.getNameForJdbcType(Types.OTHER);
assertEquals(OTHER, tn, "OTHER did not map to OTHER");
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@calcite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
