caicancai commented on code in PR #3684: URL: https://github.com/apache/calcite/pull/3684#discussion_r1494627130
########## site/_docs/reference.md: ########## @@ -2700,12 +2700,14 @@ In the following: | s | BIT_GET(value, position) | Returns the bit (0 or 1) value at the specified *position* of numeric *value*. The positions are numbered from right to left, starting at zero. The *position* argument cannot be negative | b | CEIL(value) | Similar to standard `CEIL(value)` except if *value* is an integer type, the return type is a double | m s | CHAR(integer) | Returns the character whose ASCII code is *integer* % 256, or null if *integer* < 0 +| s | CHR(integer) | Returns the character whose ASCII code is *integer* % 256, or null if *integer* < 0 Review Comment: @JiajunBernoulli @YiwenWu If some functions of spark are different from other sql engines, I do not recommend putting them in this jira, as this can easily cause confusion. We need to open a new jira to discuss it, what is the difference and what negative tests need to be added? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@calcite.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
