mihaibudiu commented on code in PR #3684:
URL: https://github.com/apache/calcite/pull/3684#discussion_r1495018416
##########
testkit/src/main/java/org/apache/calcite/test/SqlOperatorTest.java:
##########
@@ -2259,6 +2272,27 @@ private static void
checkConcatWithSeparatorInMSSQL(SqlOperatorFixture f) {
f.checkString("concat_ws('', '', '', '')", "", "VARCHAR(0) NOT NULL");
}
+ private static void checkConcatWithSeparatorInSpark(SqlOperatorFixture f) {
+ f.setFor(SqlLibraryOperators.CONCAT_WS_SPARK);
+ f.checkString("concat_ws(',', 'a')", "a", "VARCHAR(1) NOT NULL");
+ f.checkString("concat_ws(',', 'a', 'b', null, 'c')", "a,b,c",
+ "VARCHAR NOT NULL");
+ f.checkString("concat_ws(',', cast('a' as varchar), cast('b' as varchar))",
+ "a,b", "VARCHAR NOT NULL");
+ f.checkString("concat_ws(',', cast('a' as varchar(2)), cast('b' as
varchar(1)))",
+ "a,b", "VARCHAR(4) NOT NULL");
+ f.checkString("concat_ws(',', '', '', '')", ",,", "VARCHAR(2) NOT NULL");
+ f.checkString("concat_ws(',', null, null, null)", "", "VARCHAR NOT NULL");
+ // returns null if the separator is null
+ f.checkNull("concat_ws(null, 'a', 'b')");
+ f.checkNull("concat_ws(null, null, null)");
+ f.checkString("concat_ws(',')", "", "VARCHAR(0) NOT NULL");
+ // if the separator is empty string, it's equivalent to CONCAT
+ f.checkString("concat_ws('', cast('a' as varchar(2)), cast('b' as
varchar(1)))",
+ "ab", "VARCHAR(3) NOT NULL");
+ f.checkString("concat_ws('', '', '', '')", "", "VARCHAR(0) NOT NULL");
Review Comment:
the way you wrote the function description, it can accept a mix of multiple
arrays and strings too.
Can you either write tests for that case or fix the description?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
