caicancai commented on code in PR #3689:
URL: https://github.com/apache/calcite/pull/3689#discussion_r1495180029
##########
core/src/main/java/org/apache/calcite/runtime/SqlFunctions.java:
##########
@@ -2790,13 +2790,13 @@ public static double log(BigDecimal d0, BigDecimal d1) {
/** SQL {@code LOG2(number)} function applied to double values. */
public static double log2(double d0) {
- return (d0 == 0) ? Double.NaN : Math.log(d0) / Math.log(2);
+ return (Double.isInfinite(log(d0, 2))) ? Double.NaN : log(d0, 2);
Review Comment:
Mysql seems to be unable to support the parsing of +Infinity and -Infinity.
From a mathematical point of view, I am not sure whether this makes sense, but
mysql obviously does not support it. Maybe we can only deal with 0
specifically. I tested +0.0 and - 0.0 returns null
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
