caicancai commented on code in PR #3689:
URL: https://github.com/apache/calcite/pull/3689#discussion_r1496755072
##########
core/src/main/java/org/apache/calcite/adapter/enumerable/RexImpTable.java:
##########
@@ -637,6 +638,7 @@ Builder populate() {
defineMethod(EXP, BuiltInMethod.EXP.method, NullPolicy.STRICT);
defineMethod(POWER, BuiltInMethod.POWER.method, NullPolicy.STRICT);
defineMethod(ABS, BuiltInMethod.ABS.method, NullPolicy.STRICT);
+ defineMethod(LOG2, BuiltInMethod.LOG2.method, NullPolicy.STRICT);
Review Comment:
If I put it in LogImplementor, I might have to do more work than now,
because the log function in postgres and mysql obviously handles 0 differently,
so I raised jira on this issue.
https://issues.apache.org/jira/browse/CALCITE-6259
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
