tanclary commented on PR #3689: URL: https://github.com/apache/calcite/pull/3689#issuecomment-1965713776
> > I think when you get a review, you should try to make sure you didn't make the same mistakes in other places in the PR. If you fix them all at once it will save you and the reviewer time. Especially when your reviewers are in different time zones, it will help reduce the time it takes to merge the commit. > > Maybe what you said makes sense, but the commits that were merged before were written in a similar way. I learned from their writing methods. I don't understand why the previous PR can be merged if I modified it. I don't mean any harm, I just don't understand When someone writes code you use in your commit, it is polite to add them as a co-author. You used some code I wrote in this commit. Does that make sense? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
