caicancai commented on PR #3689: URL: https://github.com/apache/calcite/pull/3689#issuecomment-1965717499
> > > I think when you get a review, you should try to make sure you didn't make the same mistakes in other places in the PR. If you fix them all at once it will save you and the reviewer time. Especially when your reviewers are in different time zones, it will help reduce the time it takes to merge the commit. > > > > > > Maybe what you said makes sense, but the commits that were merged before were written in a similar way. I learned from their writing methods. I don't understand why the previous PR can be merged if I modified it. I don't mean any harm, I just don't understand > > I mean that I've noticed you make the same mistakes multiple times, even after they have been pointed out by a reviewer. You can avoid this by checking over the PR and making sure you fix all instances of a mistake so it saves everyone time. Does that make sense? > > > I think when you get a review, you should try to make sure you didn't make the same mistakes in other places in the PR. If you fix them all at once it will save you and the reviewer time. Especially when your reviewers are in different time zones, it will help reduce the time it takes to merge the commit. > > > > > > Maybe what you said makes sense, but the commits that were merged before were written in a similar way. I learned from their writing methods. I don't understand why the previous PR can be merged if I modified it. I don't mean any harm, I just don't understand > > I mean that I've noticed you make the same mistakes multiple times, even after they have been pointed out by a reviewer. You can avoid this by checking over the PR and making sure you fix all instances of a mistake so it saves everyone time. Does that make sense? My question, sorry -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@calcite.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
