rubenada commented on code in PR #3435:
URL: https://github.com/apache/calcite/pull/3435#discussion_r1517372282
##########
core/src/main/java/org/apache/calcite/sql/SqlCall.java:
##########
@@ -191,7 +191,7 @@ public int operandCount() {
* Returns a string describing the actual argument types of a call, e.g.
* "SUBSTR(VARCHAR(12), NUMBER(3,2), INTEGER)".
*/
- protected String getCallSignature(
+ public String getCallSignature(
Review Comment:
This change on method visibility, although minor, should be considered a
breaking change and IMO mentioned briefly on the RN: any downstream project
that had overridden it as `protected` would have a compilation issue with the
new version, and would need to adjust their code to override it as `public`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
