jduo commented on code in PR #3730:
URL: https://github.com/apache/calcite/pull/3730#discussion_r1525215726
##########
core/src/main/java/org/apache/calcite/runtime/SqlFunctions.java:
##########
@@ -680,8 +687,15 @@ private static int makeRegexpFlags(String stringFlags) {
flags |= Pattern.DOTALL;
break;
case 'm':
+ // PostgreSQL should actually interpret m to be a synonym for n, but
this is
+ // relaxed for consistency.
flags |= Pattern.MULTILINE;
break;
+ case 's':
Review Comment:
It was decided (in the comments for the ticket) that we'll start with a base
set of flags. There are many that can't be implemented through java.util.regex.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
