jduo commented on code in PR #3730:
URL: https://github.com/apache/calcite/pull/3730#discussion_r1525222467
##########
core/src/main/java/org/apache/calcite/runtime/SqlFunctions.java:
##########
@@ -400,11 +400,11 @@ Pattern toPattern() {
/** Validate regex arguments in REGEXP_* fns, throws an exception
* for invalid regex patterns, else returns a Pattern object. */
- private Pattern validateRegexPattern(String regex, String methodName) {
+ private Pattern validateRegexPattern(String regex, String methodName, int
flags) {
Review Comment:
Sounds good. I'll make this change. Thanks for the review @YiwenWu .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
