caicancai commented on code in PR #3732:
URL: https://github.com/apache/calcite/pull/3732#discussion_r1538391118
##########
core/src/main/java/org/apache/calcite/adapter/enumerable/RexImpTable.java:
##########
@@ -4127,14 +4130,14 @@ private static class LogicalNotImplementor extends
AbstractRexCallImplementor {
* <p>Handles all logarithm functions using log rules to determine the
* appropriate base (i.e. base e for LN).
*/
- private static class LogImplementor extends AbstractRexCallImplementor {
- LogImplementor() {
- super("log", NullPolicy.STRICT, true);
+ private static class LogImplementor extends MethodImplementor {
+ LogImplementor(Method method) {
+ super(method, NullPolicy.STRICT, true);
Review Comment:
@tanclary Hello，I have tried it before. Using AbstractRexCallImplementor
means that I need to pass a parameter to determine whether the log function
belongs to mysql or bigquery. I can completely locate it through method and
method name. This does not require me to make a judgment (because method name
can be directly mapped to Sqlfunctions method).
I think MethodImplementor is more suitable in terms of code size and
simplicity, thank you
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
