caicancai commented on code in PR #3732:
URL: https://github.com/apache/calcite/pull/3732#discussion_r1546084144
##########
core/src/main/java/org/apache/calcite/sql/fun/SqlLibraryOperators.java:
##########
@@ -2205,6 +2205,14 @@ private static RelDataType
deriveTypeMapFromEntries(SqlOperatorBinding opBinding
OperandTypes.NUMERIC_OPTIONAL_NUMERIC,
SqlFunctionCategory.NUMERIC);
+ /** The "LOG(numeric1, numeric2)" function. Returns the base numeric1
logarithm of numeric. */
+ @LibraryOperator(libraries = {MYSQL, SPARK})
Review Comment:
@tanclary How should I reasonably describe this PR title?
Add LOG function (enabled in MYSQL, Spark library) or Add LOG function
(enabled in MYSQL* library).
Before I was Add LOG function (enabled in MYSQL, Spark library), I thought
you asked me to change it to Add LOG function (enabled in MYSQL library), it
seems I didn’t understand what you meant, sorry
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
