asolimando commented on code in PR #3758:
URL: https://github.com/apache/calcite/pull/3758#discussion_r1565910366
##########
core/src/main/java/org/apache/calcite/adapter/enumerable/EnumUtils.java:
##########
@@ -354,6 +354,9 @@ public static Expression convert(Expression operand, Type
fromType,
if (!Types.needTypeCast(fromType, toType)) {
return operand;
}
+
+ // TODO consider using Expressions#convertChecked to throw exception in
case of overflow
Review Comment:
@rubenada we might want to file a ticket for this and replace `TODO` with
the ticket reference
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
