rubenada commented on code in PR #3758:
URL: https://github.com/apache/calcite/pull/3758#discussion_r1566855343
##########
core/src/main/java/org/apache/calcite/adapter/enumerable/RexToLixTranslator.java:
##########
@@ -1393,20 +1392,17 @@ private Result toInnerStorageType(Result result, Type
storageType) {
// For numeric types, use java.lang.Number to prevent cast exception
// when the parameter type differs from the target type
- Expression argumentExpression =
- EnumUtils.convert(
+ final Expression valueExpression = isNumeric
+ ? EnumUtils.convert(
+ EnumUtils.convert(
+ Expressions.call(root, BuiltInMethod.DATA_CONTEXT_GET.method,
+ Expressions.constant("?" + dynamicParam.getIndex())),
+ java.lang.Number.class),
+ storageType)
+ : EnumUtils.convert(
Expressions.call(root, BuiltInMethod.DATA_CONTEXT_GET.method,
Expressions.constant("?" + dynamicParam.getIndex())),
- isNumeric ? java.lang.Number.class : storageType);
-
- // Short-circuit if the expression evaluates to null. The cast
- // may throw a NullPointerException as it calls methods on the
- // object such as longValue().
- Expression valueExpression =
Review Comment:
Good point. I have added a new test for `null`. It works fine, it seems the
existing logic on `EnumUtils#convert` already handled that scenario correctly,
but it's good to have an explicit test confirming it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
